Exclude commons-logging dependency from Elasticsearch dependencies.#1993
Merged
sothawo merged 1 commit intospring-projects:4.3.xfrom Nov 13, 2021
Merged
Conversation
sothawo
added a commit
that referenced
this pull request
Nov 13, 2021
npepinpe
added a commit
to camunda/camunda
that referenced
this pull request
Jul 3, 2023
Spring displays a prominent warning when using different versions of `commons-logging`. They use their own variant, `spring-jcl`, and importing `commons-logging` conflicts with this. We pull in `commons-logging` via the Opensearch and Elasticsearch exporters respectively. I have not noticed any issues with logging when removing, and followed the suggestion from Spring themselves, see: spring-projects/spring-data-elasticsearch#1993
This was referenced Jul 3, 2023
ghost
pushed a commit
to camunda/camunda
that referenced
this pull request
Jul 4, 2023
13300: fix(dist): remove Spring Boot warning around commons-logging r=remcowesterhoud a=npepinpe ## Description Spring displays a prominent warning when using different versions of `commons-logging`. They use their own variant, `spring-jcl`, and importing `commons-logging` conflicts with this. We pull in `commons-logging` via the Opensearch and Elasticsearch exporters respectively. I have not noticed any issues with logging when removing, and followed the suggestion from Spring themselves, see: spring-projects/spring-data-elasticsearch#1993 ## Related issues closes #13299 Co-authored-by: Nicolas Pepin-Perreault <[email protected]>
npepinpe
added a commit
to camunda/camunda
that referenced
this pull request
Jul 17, 2023
Spring displays a prominent warning when using different versions of `commons-logging`. They use their own variant, `spring-jcl`, and importing `commons-logging` conflicts with this. We pull in `commons-logging` via the Opensearch and Elasticsearch exporters respectively. I have not noticed any issues with logging when removing, and followed the suggestion from Spring themselves, see: spring-projects/spring-data-elasticsearch#1993
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1989