Fix NPE in CrudRepositoryExtensions#3187
Closed
OsaSoft wants to merge 2 commits intospring-projects:mainfrom
Closed
Fix NPE in CrudRepositoryExtensions#3187OsaSoft wants to merge 2 commits intospring-projects:mainfrom
CrudRepositoryExtensions#3187OsaSoft wants to merge 2 commits intospring-projects:mainfrom
Conversation
|
@OsaSoft Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@OsaSoft Thank you for signing the Contributor License Agreement! |
Member
|
The type should be non-nullable indeed. We would incorporate this change for the next GA release only without backporting it as this is a breaking change in some sense regarding compiling. |
|
Just got bit by this today. Any idea when this might get released? |
CrudRepositoryExtensions
Member
|
Thank you for your contribution. That's merged now. |
mp911de
pushed a commit
that referenced
this pull request
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Erasure of nullability information was causing NPEs in the forced non-null assertion, as it allowed to pass a nullable value, see following snippet that would pass compilation correctly, but throw an unexpected NPE:
The fix enforces the generic

IDtype to be a not-null type, therefore the above code no longer compiles.Not sure how to add a test for this, since the fix is on a static-type level and the problematic code no longer compiles. Could add in a comment, I guess?