Skip to content

Allow QueryOptions to disable timeout#1495

Closed
seungh0 wants to merge 1 commit intospring-projects:mainfrom
seungh0:GH-1494-allow-zero-timeout
Closed

Allow QueryOptions to disable timeout#1495
seungh0 wants to merge 1 commit intospring-projects:mainfrom
seungh0:GH-1494-allow-zero-timeout

Conversation

@seungh0
Copy link
Copy Markdown
Contributor

@seungh0 seungh0 commented Jun 12, 2024 •
edited
Loading

Allow QueryOptions to set timeout to 0.

If it is zero, the read timeout will be disabled for this statement

Closes #1494

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 12, 2024
@seungh0 seungh0 mentioned this pull request Jun 12, 2024
Closed
@seungh0
Allow QueryOptions to set timeout to 0.
de11972 
If it is zero, the read timeout will be disabled for this statement.

Closes spring-projects#1494
@seungh0 seungh0 force-pushed the GH-1494-allow-zero-timeout branch from 19a72fa to de11972 Compare June 12, 2024 10:29
@seungh0 seungh0 changed the title Allow QueryOptions to set timeout to 0. Allow QueryOptions to set timeout to 0 Jun 12, 2024
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 12, 2024
@mp911de mp911de changed the title Allow QueryOptions to set timeout to 0 Allow QueryOptions to disable timeout Jun 12, 2024
mp911de pushed a commit that referenced this pull request Jun 12, 2024
@seungh0 @mp911de
Allow QueryOptions to disable timeout.
ef6d83e 
If it is zero, the read timeout will be disabled for this statement.

Closes #1494
Original pull request: #1495
mp911de added a commit that referenced this pull request Jun 12, 2024
@mp911de
Polishing.
d81bec1 
Delegate calls from deprecated methods to their replacement methods. Simplify tests.

See #1494
Original pull request: #1495
mp911de pushed a commit that referenced this pull request Jun 12, 2024
@seungh0 @mp911de
Allow QueryOptions to disable timeout.
74189c7 
If it is zero, the read timeout will be disabled for this statement.

Closes #1494
Original pull request: #1495
mp911de added a commit that referenced this pull request Jun 12, 2024
@mp911de
Polishing.
acbdd87 
Delegate calls from deprecated methods to their replacement methods. Simplify tests.

See #1494
Original pull request: #1495
mp911de pushed a commit that referenced this pull request Jun 12, 2024
@seungh0 @mp911de
Allow QueryOptions to disable timeout.
eae72b1 
If it is zero, the read timeout will be disabled for this statement.

Closes #1494
Original pull request: #1495
mp911de added a commit that referenced this pull request Jun 12, 2024
@mp911de
Polishing.
2832f33 
Delegate calls from deprecated methods to their replacement methods. Simplify tests.

See #1494
Original pull request: #1495
@mp911de mp911de added this to the 4.2.7 (2023.1.7) milestone Jun 12, 2024
@mp911de
Copy link
Copy Markdown
Member

mp911de commented Jun 12, 2024

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: bug A general bug

Projects

None yet

Milestone

4.2.7 (2023.1.7)

Development

Successfully merging this pull request may close these issues.

Assertion does not match its error message and comments for QueryOptions.readTimeout method

3 participants

@seungh0 @mp911de @spring-projects-issues