Repository navigation
JsonWriter writes NaN and infinite values as invalid JSON - #52477
Merged
wilkinsona merged 2 commits intoOct 29, 2026
Merged
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: bug
Previously, JsonValueWriter wrote every Number using toString(), so NaN and infinite Double and Float values were written as bare NaN, Infinity and -Infinity tokens. These are not valid JSON and, for example, made a structured log line unparseable when a key-value pair held such a value. This commit writes non-finite Double and Float values as JSON strings, matching Jackson's default behavior. Signed-off-by: Wei-Lun Li <[email protected]> See spring-projectsgh-52477
See spring-projectsgh-52477 Signed-off-by: Andy Wilkinson <[email protected]>
wilkinsona
force-pushed
the
json-writer-non-finite-numbers
branch
from
October 29, 2026 09:17
9c5f8f3 to
0bce5d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonValueWriterwrites everyNumberwithtoString(), soNaNand infiniteDouble/Floatvalues come out as bareNaN,Infinityand-Infinity, which aren't valid JSON. With structured logging this makes the whole line unparseable. For example, withlogging.structured.format.console=ecs:produces
..."ratio":NaN,....This writes non-finite
DoubleandFloatvalues as JSON strings ("NaN","Infinity","-Infinity"), which is also what Jackson does by default. Other numbers are written as before. I picked strings overnullso the value isn't lost, but I can switch tonullif you'd prefer.JsonValueWriterTests.writeWhenNonFiniteNumberfails without the change and passes with it.I used Claude Code to write this change.