Fix ID collision in MetaDataInstanceFactory for test scenarios with @SpringBatchTest#5208
Closed
HongYeseul wants to merge 1 commit intospring-projects:mainfrom
Closed
Fix ID collision in MetaDataInstanceFactory for test scenarios with @SpringBatchTest#5208HongYeseul wants to merge 1 commit intospring-projects:mainfrom
HongYeseul wants to merge 1 commit intospring-projects:mainfrom
Conversation
…tanceFactory to prevent collisions Signed-off-by: HongYeseul <[email protected]>
Contributor
|
This is great! LGTM 👍 Rebased and merged as 4f8609b. Thank you for your contribution 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tests using
StepScopeTestUtilswith@SpringBatchTestfailed withClassCastExceptiondue to ID collisions.MetaDataInstanceFactoryalways created instances with the same default IDs (123L), causing multipleStepExecutioninstances to be treated as identical inStepSynchronizationManager.Solution
Added
AtomicLongcounters to generate unique IDs for eachStepExecutionandJobExecution. This prevents context collisions while maintaining backward compatibility—the first invocation still uses the original default IDs.Changes
jobExecutionIdCounterandstepExecutionIdCounterstatic fieldscreateStepExecution(JobParameters)to useincrementAndGet()for unique IDsCloses #5181