Use Threadlocal.remove() instead of Threadlocal.set(null)#4601
Closed
Seungpang wants to merge 2 commits intospring-projects:mainfrom
Closed
Use Threadlocal.remove() instead of Threadlocal.set(null)#4601Seungpang wants to merge 2 commits intospring-projects:mainfrom
Seungpang wants to merge 2 commits intospring-projects:mainfrom
Conversation
Contributor
|
LGTM. Rebased and merged as 3b9ceea. Thank you for your contribution! |
FBibonne
pushed a commit
to FBibonne/spring-batch
that referenced
this pull request
Feb 2, 2025
Issue spring-projects#4601 Signed-off-by: Fabrice Bibonne <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Team,
This PR improves memory management by replacing instances of
ThreadLocal.set(null)withThreadLocal.remove()and removing the unnecessaryThreadLocal.set(null)in the constructor.In the current implementation,
ThreadLocal.set(null)is used to clear theThreadLocalvariable. This approach can leave theThreadLocalvariable in the thread's local variable map with a null value, potentially causing memory leaks. UsingThreadLocal.remove()instead properly removes theThreadLocalvariable from the thread's local variable map, preventing memory leaks.Additionally, the constructor for
JobFlowExecutorcontains an unnecessaryThreadLocal.set(null), which is redundant because theThreadLocalvariable is already initialized tonullby default.