Use annotation @Override consistently#4512
Closed
hpoettker wants to merge 1 commit intospring-projects:mainfrom
hpoettker:use-override-consistently
Closed
Use annotation @Override consistently#4512hpoettker wants to merge 1 commit intospring-projects:mainfrom hpoettker:use-override-consistently
@Override consistently#4512hpoettker wants to merge 1 commit intospring-projects:mainfrom
hpoettker:use-override-consistently
Conversation
Contributor
|
Merged as 0d1d89c. Thank you for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codebase currently contains some comments with "non-Javadoc", which, I think, are predeccesors in spirit to the
@Overrideannotation and have been auto-generated by IDEs in the past.This PR removes these remnants and adds the annotation
@Overridewhere it is currently missing.In the test code, I've also removed some methods in support classes that actually don't override anything.