Support full regular expression on PatterMatcher.match()#4492
Open
injae-kim wants to merge 1 commit intospring-projects:mainfrom
Open
Support full regular expression on PatterMatcher.match()#4492injae-kim wants to merge 1 commit intospring-projects:mainfrom
PatterMatcher.match()#4492injae-kim wants to merge 1 commit intospring-projects:mainfrom
Conversation
injae-kim
commented
Nov 19, 2023
Comment on lines
+226
to
+235
| if (value == null) { | ||
| for (String key : sorted) { | ||
| try { | ||
| if (matchRegex(key, line)) { | ||
| value = map.get(key); | ||
| break; | ||
| } | ||
| } catch (Throwable ignored) {} | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Maybe we can replace match() to matchRegex(), but I think it makes breaking change.
- e.g.
"*"means matching all lines onmatch(), but invalid regex format and throwsPatternSyntaxExceptiononmatchRegex() "abcde"matches"abc*"onmatch(), but not matches onmatchRegex()("abc*"matches only"abccc.."on regex)
(also PatternMatcherTests failed if we replace match() to matchRegex())
To avoid this breaking change, I intentionally matchRegex() only when there's nothing matched by match()~!
injae-kim
force-pushed
the
full-regex-pattern-matcher
branch
from
fc311df to
6c39444
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue #4412
Motivation:
PatternMatchingCompositeLineMapperdoesn't support regular expression matchingAntPathMatcherstyle matching nowModification:
PatterMatcher.match()that used onPatternMatchingCompositeLineMapper.mapLine()Result:
PatternMatchingCompositeLineMapper.mapLine()