Documentation Update to scalability.adoc#4338
Closed
kajsa wants to merge 1 commit intospring-projects:mainfrom
Closed
Documentation Update to scalability.adoc#4338kajsa wants to merge 1 commit intospring-projects:mainfrom
kajsa wants to merge 1 commit intospring-projects:mainfrom
Conversation
Move commentary on xml configuration just below the configuration it's explaining, instead of having it in the middle of the Java configuration example.
|
@kajsa Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
Contributor
Author
|
@pivotal-cla This is an Obvious Fix |
|
@kajsa This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary. |
kajsa
changed the title
fmbenhassine
pushed a commit
that referenced
this pull request
Mar 29, 2023
Move commentary on xml configuration just below the configuration it's explaining, instead of having it in the middle of the Java configuration example. Issue #4338
Contributor
|
Good catch! LGTM. Rebased and merged as 74be83a. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move commentary on xml configuration just below the configuration it's explaining, instead of having it in the middle of the Java configuration example.
This seems to me to fit the criteria for "obvious fix", but please let me know if you disagree.