Skip to content

Consider logging missing code_challenge when PKCE is required #1247

Closed
Closed
Consider logging missing code_challenge when PKCE is required#1247
Assignees
sjohnr
Labels
type: enhancementA general enhancement
Milestone
1.2.0-M1
@sjohnr

Description

@sjohnr
sjohnr
opened on May 30, 2023

spring-authorization-server/oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/authentication/CodeVerifierAuthenticator.java

Lines 97 to 99 in 27a893f

if (!StringUtils.hasText(codeChallenge)) {
if (registeredClient.getClientSettings().isRequireProofKey()) {
throwInvalidGrant(PkceParameterNames.CODE_CHALLENGE);

We should consider adding a log entry at DEBUG level in CodeVerifierAuthenticator for this case. This would allow the logging level to be tuned specifically for this logging.

Metadata

Metadata

Assignees

Labels

type: enhancementA general enhancement

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions