feat: add classic queue type option to QueueBuilder#3356
Merged
artembilan merged 2 commits intospring-projects:mainfrom Feb 24, 2026
Merged
feat: add classic queue type option to QueueBuilder#3356artembilan merged 2 commits intospring-projects:mainfrom
artembilan merged 2 commits intospring-projects:mainfrom
Conversation
"QueueBuilder" sets the default queue type if no argument is provided. Judging by the fact that "classic()" option doesn't exist, it is believed that the default type is always "classic". But it could be any. In my project, SRE set the default type to "quorum". And I had to override with "withArguments" method. I think that we also need more convenient "classic" method. Signed-off-by: Amedov Bekmuhamet <[email protected]>
artembilan
requested changes
Feb 23, 2026
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
This makes sense.
Please, fix the @since version and we will merge this.
Thank you!
spring-amqp/src/main/java/org/springframework/amqp/core/QueueBuilder.java
Outdated
Show resolved
Hide resolved
Updated the since version for classic queue method. Signed-off-by: Amedov Bekmuhamet <[email protected]>
Member
|
Thank you for contribution; looking forward for more! |
spring-builds
pushed a commit
that referenced
this pull request
Feb 24, 2026
Fixes: #3356 `QueueBuilder` sets the default queue type if no argument is provided. Judging by the fact that `classic()` option doesn't exist, it is believed that the default type is always `classic`. But it could be any. In my project, SRE set the default type to `quorum`. And I had to override with `withArguments` method. I think that we also need more convenient `classic` method. * Change classic method since version to 3.2.10 Signed-off-by: Amedov Bekmuhamet <[email protected]> (cherry picked from commit 4ccd299)
spring-builds
pushed a commit
that referenced
this pull request
Feb 24, 2026
Fixes: #3356 `QueueBuilder` sets the default queue type if no argument is provided. Judging by the fact that `classic()` option doesn't exist, it is believed that the default type is always `classic`. But it could be any. In my project, SRE set the default type to `quorum`. And I had to override with `withArguments` method. I think that we also need more convenient `classic` method. * Change classic method since version to 3.2.10 Signed-off-by: Amedov Bekmuhamet <[email protected]> (cherry picked from commit 4ccd299)
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"QueueBuilder" sets the default queue type if no argument is provided. Judging by the fact that "classic()" option doesn't exist, it is believed that the default type is always "classic". But it could be any.
In my project, SRE set the default type to "quorum". And I had to override with "withArguments" method. I think that we also need more convenient "classic" method.