Optimize ArrayList allocations#3233
Merged
cppwfs merged 2 commits intospring-projects:mainfrom Nov 13, 2025
Merged
Conversation
Fix `new ArrayList()` calls with explicit size or collection copy whenever it is possible or reasonable
Member
Author
|
More info in: spring-projects/spring-kafka#4152 |
cppwfs
requested changes
Nov 12, 2025
Contributor
cppwfs
left a comment
cppwfs
left a comment
There was a problem hiding this comment.
Great optimization. One nitpick
|
|
||
| /** | ||
| * @return The target object to delegate message listening to. | ||
| * @return The target objects to delegate a message listening to. |
Contributor
There was a problem hiding this comment.
I think object (single) is proper here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
new ArrayList()calls with explicit size or collection copy whenever it is possible or reasonable