GH-1491: Fix Fallback When Parameter is Optional

garyrussell · garyrussell · commit f2e1e983170f · 2022-08-10T12:24:43.000-04:00
Only pass `Optional.empty()` if the method parameter is `Optional`.
diff --git a/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/annotation/RabbitListenerAnnotationBeanPostProcessor.java b/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/annotation/RabbitListenerAnnotationBeanPostProcessor.java
@@ -18,6 +18,8 @@
 
 import java.lang.reflect.AnnotatedElement;
 import java.lang.reflect.Method;
+import java.lang.reflect.ParameterizedType;
+import java.lang.reflect.Type;
 import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
@@ -1054,7 +1056,8 @@ public Object resolveArgument(MethodParameter parameter, Message<?> message) thr
 				resolved = super.resolveArgument(parameter, message);
 			}
 			catch (MethodArgumentNotValidException ex) {
-				if (message.getPayload().equals(Optional.empty())) {
+				Type type = parameter.getGenericParameterType();
+				if (isOptional(message, type)) {
 					BindingResult bindingResult = ex.getBindingResult();
 					if (bindingResult != null) {
 						List<ObjectError> allErrors = bindingResult.getAllErrors();
@@ -1082,6 +1085,12 @@ public Object resolveArgument(MethodParameter parameter, Message<?> message) thr
 			return resolved;
 		}
 
+		private boolean isOptional(Message<?> message, Type type) {
+			return (Optional.class.equals(type) || (type instanceof ParameterizedType
+						&& Optional.class.equals(((ParameterizedType) type).getRawType())))
+					&& message.getPayload().equals(Optional.empty());
+		}
+
 		@Override
 		protected boolean isEmptyPayload(Object payload) {
 			return payload == null || payload.equals(Optional.empty());
