GH-5191: Fix Neo4jVectorStore doAdd method ignoring sessionConfig #5200
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pilhwan Choi <[email protected]>
ilayaperumalg
approved these changes
Jan 7, 2026
Member
|
@thisishwan2 Thanks for the PR! Rebased and merged via 042d9a7. Also, added integration tests to validate the changes via f3445d1. Pushed the changes into 1.1.x as well via 99127f6 and 3293a20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-5191
Description
This PR fixes a bug where the
doAddmethod inNeo4jVectorStorewas ignoring the user-configuredsessionConfig.Previously,
doAddinitialized the session usingthis.driver.session(), which falls back to the default database configuration. This caused connection errors when a custom database name was specified inNeo4jVectorStoreConfig.Changes:
doAddto usethis.driver.session(this.sessionConfig)to ensure the configured session settings (e.g., database name) are respected.Verification
doDeleteordoSearch) initialize the session in this class.