Skip to content

fix(observability): register ObservationRegistry for dynamic MessageChannels in StreamBridge (#3033)#3036

Closed
agustino-lim wants to merge 1 commit intospring-cloud:mainfrom
agustino-lim:GH-3033
Closed

fix(observability): register ObservationRegistry for dynamic MessageChannels in StreamBridge (#3033)#3036
agustino-lim wants to merge 1 commit intospring-cloud:mainfrom
agustino-lim:GH-3033

Conversation

@agustino-lim
Copy link
Copy Markdown
Contributor

This PR addresses issue #3033 by ensuring ObservationRegistry is registered for dynamically created MessageChannel in StreamBridge

@agustino-lim agustino-lim force-pushed the GH-3033 branch 2 times, most recently from 0ebc94c to a141828 Compare November 8, 2024 09:05
@olegz
Copy link
Copy Markdown
Contributor

olegz commented Nov 18, 2024

Thank you for your contribution.
Can you please rebase and update your PR, as there are test failures in Rabbit binder, perhaps due few recent changes to StreamBridge

@agustino-lim agustino-lim force-pushed the GH-3033 branch 2 times, most recently from 9bbc08f to 8546394 Compare November 18, 2024 15:16
@agustino-lim
Copy link
Copy Markdown
Contributor Author

Thank you for your feedback! I have rebased my branch and addressed the test failures related to the Rabbit binder. Please let me know if there’s anything else that needs to be updated.

@agustino-lim agustino-lim force-pushed the GH-3033 branch 2 times, most recently from f50895e to c16a40c Compare November 25, 2024 12:50
…Channels

Fixes: spring-cloudgh-3033

* ensure `ObservationRegistry` is registered on dynamically created `MessageChannel` instances in `StreamBridge`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants