Change the use of synchronized in the getBinder method of DefaultBinderFactory class for virtual-threads compliant#3005
Merged
olegz merged 1 commit intospring-cloud:mainfrom Sep 24, 2024
Conversation
…erFactory class for virtual-threads The getBinder method in DefaultBinderFactory was made thread-safe using ReentrantLock. This commit ensures that the method is friendly for virtual threads to avoid blocking and pinning. The lock is acquired at the beginning of the method and released in a finally block to ensure it is always released, even if an exception occurs. Fixes spring-cloudgh-3004
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3004
This pull request includes changes to the
DefaultBinderFactoryclass to improve thread safety by introducing aReentrantLock. The most important changes include adding the lock, modifying thegetBindermethod to use the lock, and ensuring the lock is released properly.Thread safety improvements:
core/spring-cloud-stream/src/main/java/org/springframework/cloud/stream/binder/DefaultBinderFactory.java: ImportedReentrantLockand declared a static final instance of it. [1] [2]core/spring-cloud-stream/src/main/java/org/springframework/cloud/stream/binder/DefaultBinderFactory.java: Modified thegetBindermethod to lock and unlock using theReentrantLock. Removed thesynchronizedkeyword from the method signature. [1] [2]