Skip to content

GH-2847: Multiple outputs routing-key-expression#2864

Merged
olegz merged 1 commit intospring-cloud:mainfrom
sobychacko:gh-2847
Dec 6, 2023
Merged

GH-2847: Multiple outputs routing-key-expression#2864
olegz merged 1 commit intospring-cloud:mainfrom
sobychacko:gh-2847

Conversation

@sobychacko
Copy link
Copy Markdown
Contributor

  • When there are multiple output bindings present and one of them defines a routing-key-expression, there is a bug that bypasses the code that skips the output conversion. This results in the framework attempts a pre-mature type conversion causing in later downstream errors. This happens because MessageConverterConfigurer tries to find a corresponding function for the entire function definition rather than using the individual function under consideraion. Fixing this issue by properly keeping track of the function name keyed off of the channel name, since channel name is what MessageConverterConfigurer uses to retrieve info about the function name.

Resolves #2847

 - When there are multiple output bindings present and one of them defines
   a routing-key-expression, there is a bug that bypasses the code that skips
   the output conversion. This results in the framework attempts a pre-mature
   type conversion causing in later downstream errors. This happens because
   MessageConverterConfigurer tries to find a corresponding function for the
   entire function definition rather than using the individual function under
   consideraion. Fixing this issue by properly keeping track of the function
   name keyed off of the channel name, since channel name is what
   MessageConverterConfigurer uses to retrieve info about the function name.

Resolves spring-cloud#2847
@olegz olegz merged commit 620818b into spring-cloud:main Dec 6, 2023
@olegz olegz added the bug label Dec 6, 2023
@olegz olegz added this to the 4.1.0 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple output bindings with routing-key-expression property and not with it cause SpEL evaluation error

2 participants