StreamBridge's dynamic destinations should be closed on shutdown.#2835
StreamBridge's dynamic destinations should be closed on shutdown.#2835kurthong wants to merge 1 commit intospring-cloud:mainfrom
Conversation
kurthong
commented
Oct 20, 2023
- if not, we might lose some messages on shutdown especially in case of kafka async mode producing.
- if not, we might lose some messages on shutdown especially in case of kafka async mode producing.
- if not, we might lose some messages on shutdown especially in case of kafka async mode producing. Resolves #2835
|
@olegz, Would you mind to explain why this PR was just closed, not merged? |
|
@kurthong This PR is merged upstream in |
@sobychacko Therefore, the pull request itself is And contributors would be proud of that their PRs are merged into one of their favorite projects:-) I hope you understand. |
|
I don't follow what the issue is. I see your commit from this PR in the main commit history. https://github.com/spring-cloud/spring-cloud-stream/commits/main |
|
@sobychacko If you still don't understand what I mean, please let it go. It's not that big deal. |




