Fix simple typo on Configuration Properties page#993
Merged
OlgaMaciaszek merged 3 commits intospring-cloud:mainfrom Mar 20, 2024
djkeh:fix-typo
Merged
Fix simple typo on Configuration Properties page#993OlgaMaciaszek merged 3 commits intospring-cloud:mainfrom djkeh:fix-typo
OlgaMaciaszek merged 3 commits intospring-cloud:mainfrom
djkeh:fix-typo
Conversation
|
@djkeh Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@djkeh Thank you for signing the Contributor License Agreement! |
OlgaMaciaszek
requested changes
Mar 19, 2024
Collaborator
OlgaMaciaszek
left a comment
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Hello @djkeh. Thanks for the contribution. This file is auto-generated. You need to change it in spring-cloud-openfeign-core/src/main/resources/META-INF/additional-spring-configuration-metadata.json instead. Then you can just run ./mvnw clean install -Pdocs to regenerate this file.
Contributor
Author
|
Thanks @OlgaMaciaszek, I understood and fixed the typo using the right way. |
OlgaMaciaszek
approved these changes
Mar 20, 2024
Collaborator
OlgaMaciaszek
left a comment
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Thanks @djkeh. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes typo in description of the configuration property
spring.cloud.openfeign.circuitbreaker.group.enabled.Thanks.