Add HttpClientBuilderCustomizer interface#890
Add HttpClientBuilderCustomizer interface#890OlgaMaciaszek merged 1 commit intospring-cloud:mainfrom bananayong:main
Conversation
| httpClientProperties.getHc5().getConnectionRequestTimeoutUnit())) | ||
| .build()); | ||
|
|
||
| HttpClientBuilderCustomizer customizer = customizerProvider.getIfAvailable(); |
There was a problem hiding this comment.
Usually there is a list of this type of bean so there can be multiple contributions
There was a problem hiding this comment.
Done. thx fast feedback!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #890 +/- ##
=========================================
Coverage 77.09% 77.10%
- Complexity 582 583 +1
=========================================
Files 71 71
Lines 2296 2297 +1
Branches 308 308
=========================================
+ Hits 1770 1771 +1
Misses 357 357
Partials 169 169
|
|
I hope to ship this PR in the next release. 🙏 |
|
Thanks for the PR, @bananayong . Could you please add a test and document the feature? |
OlgaMaciaszek
left a comment
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Thanks for the PR @bananayong. Please add a test and document the feature.
OlgaMaciaszek
added
enhancement
|
@OlgaMaciaszek Thank your feedback! |
|
Is there any progress? @OlgaMaciaszek |
|
If I need more work, please let me know. |
OlgaMaciaszek
left a comment
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Thanks, @bananayong, looks good. Please just update the license entries to -2023 and add your full name with @author tag to the javadocs of the classes you've changed - then it'll be ready to merge.
|
@OlgaMaciaszek Done. Please review 🙇 |
OlgaMaciaszek
left a comment
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Thanks, @bananayong - have noticed one more place lacking documentation. Please see the comment.
In addition to leveraging existing Spring Cloud settings, provide the ability for a user to customize settings.
OlgaMaciaszek
left a comment
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Thanks, @bananayong. LGTM.
5 participants
Hi, Olga.
I always thank for your efforts.
I would like to provide the ability for a user to customize settings, In addition to leveraging existing Spring Cloud settings.
In the previous version, ApacheHttpClientFactory interface existed. So I could customize HttpClientBuilder additionally.
But, in the current version, there is no method for HttpClientBuilder configurations.
Thank you!