Make Content-Encoding configurable#1071
Merged
OlgaMaciaszek merged 4 commits intospring-cloud:mainfrom Sep 25, 2024
Merged
Conversation
A new configuration property was added to make the Content-Encoding configurable when using the feign request compression. The default values are the same as the previous hardcoded values. Closes issue 1048
OlgaMaciaszek
requested changes
Sep 10, 2024
Collaborator
OlgaMaciaszek
left a comment
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Hi @AndreTeigler, thanks for the PR. Have requested some changes, mostly minor. Please address the comments.
A new configuration property was added to make the Content-Encoding configurable when using the feign request compression. The default values are the same as the previous hardcoded values. Closes issue 1048
OlgaMaciaszek
requested changes
Sep 13, 2024
Collaborator
OlgaMaciaszek
left a comment
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Thanks a lot @AndreTeigler. I have added some more comments.
A new configuration property was added to make the Content-Encoding configurable when using the feign request compression. The default values are the same as the previous hardcoded values. Closes issue 1048
OlgaMaciaszek
approved these changes
Sep 25, 2024
Collaborator
OlgaMaciaszek
left a comment
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Thanks @AndreTeigler. LGTM.
OlgaMaciaszek
pushed a commit
that referenced
this pull request
Sep 25, 2024
* Make Content-Encoding configurable A new configuration property was added to make the Content-Encoding configurable when using the feign request compression. The default values are the same as the previous hardcoded values. Closes issue 1048
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new configuration property was added to make the Content-Encoding configurable when using the feign request compression. The default values are the same as the previous hardcoded values.
Fixes gh-1048