polishing FeignClientsRegistrar#1038
Conversation
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Hello @birariro, I'm not sure why you've proposed this change. We do need to use beanFactory to properly resolve the attributes.
|
Hello @OlgaMaciaszek
And |
|
Keep the for testing comment |
|
@birariro It's helpful to know that the visibility level has been raised or sth has been added for testing purposes. That's why we put these comments there, but actually in this case, if we remove the other overloaded method, it should be |
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Thanks @birariro. Looks good. Can you please just add your full name and surname with @author tag to the javadoc of the class and update the date in the license comment to 2013-2024?
|
@OlgaMaciaszek I have applied the changes as requested. |
getName (Map<String, Object>)does not need to be for test purposes.