Make JDK HttpClient customizable#1000
Merged
OlgaMaciaszek merged 4 commits intospring-cloud:mainfrom Mar 20, 2024
Merged
Conversation
OlgaMaciaszek
requested changes
Mar 19, 2024
Collaborator
OlgaMaciaszek
left a comment
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Hello @driverpt, thanks for creating the PR. Please address the comments. Also, please add a test (you can use Spring Boot's ApplicationContextRunner).
OlgaMaciaszek
added
waiting for feedback
enhancement
OlgaMaciaszek
requested changes
Mar 20, 2024
Collaborator
OlgaMaciaszek
left a comment
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Thanks @driverpt . LGTM. Just one more cosmetic things in the javadocs - please address.
OlgaMaciaszek
approved these changes
Mar 20, 2024
Collaborator
OlgaMaciaszek
left a comment
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Thanks @driverpt. LGTM.
OlgaMaciaszek
requested changes
Mar 20, 2024
Collaborator
There was a problem hiding this comment.
@driverpt, actually, there seem to be checkstyle issues. Please fix.
Contributor
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #999