Add null param check for StandardPodUtils and Unit test#40
Merged
spencergibb merged 1 commit intospring-cloud:masterfrom Jan 30, 2017
Merged
Add null param check for StandardPodUtils and Unit test#40spencergibb merged 1 commit intospring-cloud:masterfrom
spencergibb merged 1 commit intospring-cloud:masterfrom
Conversation
Add unit test for StandardPodUtils
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small start to #26!
Added a null check in StandardPodUtils, since an instance with a null Kube client would have limited usefulness and we should protect developers from a configuration error. If a developer decides not to use a KubernetesClient, they should probably implement the PodUtils interface and supply an alternate implementation instead of passing null to StandardPodUtils.
Holding off on additional tests for StandardPodUtils for now, since it will be tricky to simulate running inside a pod because of the file system checks, and we can't guarantee that the test is running outside of a pod.