Skip to content

drop repackage from integration tests root pom#1889

Merged
ryanjbaxter merged 1 commit intospring-cloud:3.1.xfrom
wind57:test_why_we_need_repackage
Mar 10, 2025
Merged

drop repackage from integration tests root pom#1889
ryanjbaxter merged 1 commit intospring-cloud:3.1.xfrom
wind57:test_why_we_need_repackage

Conversation

@wind57
Copy link
Copy Markdown
Contributor

@wind57 wind57 commented Mar 9, 2025

No description provided.

Signed-off-by: wind57 <[email protected]>
@wind57 wind57 changed the title test drop repackage from controllers integration tests Mar 9, 2025
@wind57 wind57 marked this pull request as ready for review March 9, 2025 15:26
@wind57
Copy link
Copy Markdown
Contributor Author

wind57 commented Mar 9, 2025

@ryanjbaxter minor simplification, thank you

@ryanjbaxter
Copy link
Copy Markdown
Contributor

Did you get an understanding of why this was here in the first place?

@wind57
Copy link
Copy Markdown
Contributor Author

wind57 commented Mar 9, 2025

the truth is that I added it there, and from what I recall I was trying at the time to move the spring-boot-maven-plugin to the root pom of the integration tests. That was not working smoothly as I wanted it to be, initially, so I was trying many things, adding this part (that I now have removed), was one of the tests, that should have not been there in the first place.

@wind57 wind57 changed the title drop repackage from controllers integration tests drop repackage from integration tests root pom Mar 10, 2025
@ryanjbaxter ryanjbaxter added this to the 3.1.6 milestone Mar 10, 2025
@ryanjbaxter ryanjbaxter merged commit 7b646ad into spring-cloud:3.1.x Mar 10, 2025
@github-project-automation github-project-automation Bot moved this to Done in 2023.0.6 Mar 10, 2025
@github-project-automation github-project-automation Bot moved this to Done in 2024.0.1 Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done
Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants