Keep the original JAR when repackaging (#1456)#1888
Keep the original JAR when repackaging (#1456)#1888david-vana wants to merge 1 commit intospring-cloud:3.2.xfrom
Conversation
Added a classifier for the 'repackage' execution defined here and also for the 'default' execution defined in the spring-cloud-build parent pom. Signed-off-by: David Vana <[email protected]>
| </execution> | ||
| <execution> | ||
| <goals> | ||
| <goal>repackage</goal> |
There was a problem hiding this comment.
you PR made me realize that we do not need the second one... here is the simplification that I hope will be merged tomorrow.
There was a problem hiding this comment.
Your PR removes repackage execution from integration-tests submodule. How it is related to my changes in contollers submodule?
There was a problem hiding this comment.
snap! you're right, they are un-related indeed. my head was in the integration tests at that moment, were controllers are used, so I confused things a bit. Sorry about that!
|
I think this one should be against |
|
Yes it would be ideal if this was made against the 3.1.x branch and I will merge it forward |
|
Closing this PR in favor of new one #1891 with correct target branch 3.1.x. |
4 participants
Fix for #1456
Added a classifier for the 'repackage' execution defined here and also for the 'default' execution defined in the spring-cloud-build parent pom.