dont create a bean when not needed#1881
Merged
ryanjbaxter merged 2 commits intospring-cloud:3.1.xfrom Feb 25, 2025
wind57:dont_create_http_refersh_trigger
Merged
dont create a bean when not needed#1881ryanjbaxter merged 2 commits intospring-cloud:3.1.xfrom wind57:dont_create_http_refersh_trigger
ryanjbaxter merged 2 commits intospring-cloud:3.1.xfrom
wind57:dont_create_http_refersh_trigger
Conversation
Signed-off-by: wind57 <[email protected]>
wind57
commented
Feb 22, 2025
|
|
||
| @Bean | ||
| @ConditionalOnMissingBean | ||
| @Profile({ NOT_AMQP_NOT_KAFKA }) |
Contributor
Author
There was a problem hiding this comment.
I am proposing to do this change here, create the HttpRefreshTrigger bean only when the profile is not bus-amqp and not bus-kafka
Contributor
Author
There was a problem hiding this comment.
IMO this should have been present initially, but I missed it too a while ago. It came out as I was working on refactoring ITs
Contributor
Author
|
@ryanjbaxter let me know if you agree with this or not... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.