refactor kafka event bus integration test#1879
Merged
ryanjbaxter merged 9 commits intospring-cloud:3.1.xfrom Mar 8, 2025
wind57:refactor_k8s_kafka
Merged
refactor kafka event bus integration test#1879ryanjbaxter merged 9 commits intospring-cloud:3.1.xfrom wind57:refactor_k8s_kafka
ryanjbaxter merged 9 commits intospring-cloud:3.1.xfrom
wind57:refactor_k8s_kafka
Conversation
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
wind57
commented
Mar 7, 2025
| <packaging>pom</packaging> | ||
|
|
||
| <modules> | ||
| <module>kafka-configmap-app-a</module> |
Contributor
Author
There was a problem hiding this comment.
instead of two applications, use just one. The idea of this integration test was that we were having:
spring.cloud.kubernetes.configmap.apps=app-a, app-b
and we were building these two apps app-a and app-b and testing that a remote refresh event was received in both of them. But we can test the same exact thing with a single application, and the assertions would still be the same.
Contributor
Author
|
@ryanjbaxter ready to be looked at. thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.