refactor k8s discovery module in integration tests (1)#1865
Merged
ryanjbaxter merged 3 commits intospring-cloud:3.1.xfrom Feb 9, 2025
wind57:refactor_k8s_client_discovery
Merged
refactor k8s discovery module in integration tests (1)#1865ryanjbaxter merged 3 commits intospring-cloud:3.1.xfrom wind57:refactor_k8s_client_discovery
ryanjbaxter merged 3 commits intospring-cloud:3.1.xfrom
wind57:refactor_k8s_client_discovery
Conversation
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
wind57
changed the title
Contributor
Author
|
@ryanjbaxter this is ready to be looked at. It refactors (and drops a lot of overlapping tests) one more integration test in the k8s-client realm. Nothing else changes, just one package in an integration test maven module |
wind57
changed the title
Contributor
|
@wind57 looks like there is an issue with some mocks? |
Contributor
Author
|
I don't know :) what am I missing? |
Contributor
Author
|
hmm, I think you are referring to this one: https://github.com/spring-cloud/spring-cloud-kubernetes/actions/runs/13228659177/job/36922800954 checking. |
Contributor
Author
|
will be fixed as part of this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.