try to fix failing tests#1841
Merged
ryanjbaxter merged 2 commits intospring-cloud:3.1.xfrom Jan 17, 2025
wind57:try_to_fix_failling_tests
Merged
try to fix failing tests#1841ryanjbaxter merged 2 commits intospring-cloud:3.1.xfrom wind57:try_to_fix_failling_tests
ryanjbaxter merged 2 commits intospring-cloud:3.1.xfrom
wind57:try_to_fix_failling_tests
Conversation
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Contributor
Author
|
@ryanjbaxter this is now ready to be looked at. In general, I did not find anything obvious of why they fail, but this PR should help to narrow the issue further, if it will be required. Really sorry they fail there, every time that happens, I don't feel comfortable at all. Thank you for looking into this one. |
Contributor
|
Dont be sorry at all, it is no big deal, we will get it figured out |
Contributor
|
This appears to have fixed it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.