Fix 1661#1662
Merged
ryanjbaxter merged 172 commits intospring-cloud:mainfrom Jun 10, 2024
wind57:fix-1661
Merged
Conversation
Configure Renovate
Contributor
Author
|
merged latest main, after the release last week. @ryanjbaxter this one is ready |
Contributor
Author
|
@ryanjbaxter friendly reminder... |
|
What are you waiting for? We are waiting for this fix to get rid of the workaround. |
| @@ -106,7 +106,7 @@ public void setNamespace(String namespace) { | |||
| } | |||
|
|
|||
| public String getNamespace(String defaultValue) { | |||
There was a problem hiding this comment.
We also noticed it...
Maybe this method should be renamed to getNamespaceOrDefault ?
Contributor
Author
There was a problem hiding this comment.
it can't be renamed since it is public
amb-irek-sojka-pt
approved these changes
Jun 10, 2024
|
@ryanjbaxter when you gonna release this fix? |
Contributor
|
Sorry for the delay. Other work is taking priority at the moment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.