Fabric leader clean up 7#1648
Merged
ryanjbaxter merged 176 commits intospring-cloud:mainfrom Apr 30, 2024
wind57:fabric-leader-clean-up-7
Merged
Fabric leader clean up 7#1648ryanjbaxter merged 176 commits intospring-cloud:mainfrom wind57:fabric-leader-clean-up-7
ryanjbaxter merged 176 commits intospring-cloud:mainfrom
wind57:fabric-leader-clean-up-7
Conversation
Configure Renovate
wind57
commented
Apr 30, 2024
| @@ -52,47 +55,47 @@ public Fabric8LeaderRecordWatcher(LeaderProperties leaderProperties, | |||
| } | |||
|
|
|||
| public void start() { | |||
Contributor
Author
There was a problem hiding this comment.
the code here does not change, just wrap with guarded... as we do in other places and make Watch as volatile, so that access to it is not always under a lock if already seen by some thread as set
Contributor
Author
|
@ryanjbaxter ready to be looked at. thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.