Skip to content

Move endpoints ports to commons#1395

Merged
ryanjbaxter merged 14 commits intospring-cloud:mainfrom
wind57:move-endpointsPorts-to-commons
Aug 3, 2023
Merged

Move endpoints ports to commons#1395
ryanjbaxter merged 14 commits intospring-cloud:mainfrom
wind57:move-endpointsPorts-to-commons

Conversation

@wind57
Copy link
Copy Markdown
Contributor

@wind57 wind57 commented Aug 2, 2023

No description provided.

@@ -0,0 +1,18 @@
<configuration>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will fix the build failure too

@wind57 wind57 marked this pull request as ready for review August 3, 2023 07:14
@wind57
Copy link
Copy Markdown
Contributor Author

wind57 commented Aug 3, 2023

@ryanjbaxter one more PR in the same direction of aligning k8s and fabric8 discovery. It also fixes the current build failure

@ryanjbaxter ryanjbaxter added this to the 3.0.5 milestone Aug 3, 2023
@ryanjbaxter ryanjbaxter merged commit f08d0a5 into spring-cloud:main Aug 3, 2023
@ryanjbaxter
Copy link
Copy Markdown
Contributor

Just noticed this was against main, I assume it should also be in 3.0.x? I can cherry pick it back if so

@wind57
Copy link
Copy Markdown
Contributor Author

wind57 commented Aug 3, 2023

yeah, totally my bad, it must be in 3.0.x too :(

ryanjbaxter pushed a commit that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants