Describe the bug
Starting with Spring Cloud 2023.0.2/Spring Cloud Kubernetes 3.1.2, LeaderProperties.getNamespace(String default) is broken. As of commit 53fa5555, the method no longer falls back to the given defaultValue when namespace is not defined.
With 3.1.1, we return the defaultValue if the namespace is undefined (as expected):
|
public String getNamespace(String defaultValue) { |
|
if (this.namespace == null || this.namespace.isEmpty()) { |
|
return defaultValue; |
|
} |
|
|
|
return this.namespace; |
|
} |
With 3.1.2, we return the
namespace if the
defaultValue is defined (unexpected):
|
public String getNamespace(String defaultValue) { |
|
if (!StringUtils.hasText(defaultValue)) { |
|
return defaultValue; |
|
} |
|
|
|
return namespace; |
|
} |
This was likely the intention:
public String getNamespace(String defaultValue) {
if (!StringUtils.hasText(namespace)) {
return defaultValue;
}
return namespace;
}Applications that are not configuring spring.cloud.kubernetes.leader.namespace explicitly, relying on the auto-detected current namespace as the default will no longer work.
This is was accidentally introduced by the Fabric8 Leader refactoring made with #1648.
Impact
My application fails to start with this error:
io.fabric8.kubernetes.client.KubernetesClientException: namespace cannot be null
at io.fabric8.kubernetes.client.dsl.internal.BaseOperation.inNamespace(BaseOperation.java:252)
at io.fabric8.kubernetes.client.dsl.internal.BaseOperation.inNamespace(BaseOperation.java:97)
at org.springframework.cloud.kubernetes.fabric8.leader.Fabric8LeaderRecordWatcher.lambda$start$1(Fabric8LeaderRecordWatcher.java:63)
at org.springframework.cloud.kubernetes.commons.leader.LeaderUtils.guarded(LeaderUtils.java:51)
at org.springframework.cloud.kubernetes.fabric8.leader.Fabric8LeaderRecordWatcher.start(Fabric8LeaderRecordWatcher.java:59)
at org.springframework.cloud.kubernetes.commons.leader.LeaderInitiator.start(LeaderInitiator.java:62)
at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:288)
Describe the bug
Starting with Spring Cloud 2023.0.2/Spring Cloud Kubernetes 3.1.2,
LeaderProperties.getNamespace(String default)is broken. As of commit 53fa5555, the method no longer falls back to the givendefaultValuewhennamespaceis not defined.With 3.1.1, we return the
defaultValueif thenamespaceis undefined (as expected):spring-cloud-kubernetes/spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/leader/LeaderProperties.java
Lines 121 to 127 in 2c9e4f0
With 3.1.2, we return the
namespaceif thedefaultValueis defined (unexpected):spring-cloud-kubernetes/spring-cloud-kubernetes-commons/src/main/java/org/springframework/cloud/kubernetes/commons/leader/LeaderProperties.java
Lines 108 to 114 in 979bc62
This was likely the intention:
Applications that are not configuring
spring.cloud.kubernetes.leader.namespaceexplicitly, relying on the auto-detected current namespace as the default will no longer work.This is was accidentally introduced by the Fabric8 Leader refactoring made with #1648.
Impact
My application fails to start with this error: