Use correct key for shortcut field in SetRequestUriGatewayFilterFactory#4064
Merged
ryanjbaxter merged 1 commit intospring-cloud:4.3.xfrom Feb 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a critical bug in the SetRequestUriGatewayFilterFactory where shortcut configuration syntax (e.g., - SetRequestUri=http://127.0.0.1:8081) was causing NullPointerException. The issue was caused by a mismatch between the field name returned by shortcutFieldOrder() and the actual property name in the Config class.
Changes:
- Updated
shortcutFieldOrder()to return "template" instead of "name" (defined via NAME_KEY) to match the Config class's template field - Added TEMPLATE_KEY constant for consistency with other similar gateway filter factories
- Added unit test to verify the correct shortcut field order
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SetRequestUriGatewayFilterFactory.java | Fixed shortcutFieldOrder() to return "template" matching Config.template field, added TEMPLATE_KEY constant |
| SetRequestUriGatewayFilterFactoryTests.java | Added test to verify shortcutFieldOrder() returns "template" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spencergibb
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4062