Skip to content

Support for reloading httpClient connectTimeout Configuration#3679

Merged
ryanjbaxter merged 2 commits intospring-cloud:4.1.xfrom
qnnn:refreshable-connectTimeout
Apr 23, 2025
Merged

Support for reloading httpClient connectTimeout Configuration#3679
ryanjbaxter merged 2 commits intospring-cloud:4.1.xfrom
qnnn:refreshable-connectTimeout

Conversation

@qnnn
Copy link
Copy Markdown
Contributor

@qnnn qnnn commented Jan 23, 2025

Enabling it to be refreshed dynamically, similar to the httpClient responseTimeout configuration.

Copy link
Copy Markdown
Member

@spencergibb spencergibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a test

@qnnn
Copy link
Copy Markdown
Contributor Author

qnnn commented Jan 23, 2025

please add a test

Just added.

@qnnn qnnn force-pushed the refreshable-connectTimeout branch from 6f5d009 to 93fa296 Compare January 23, 2025 18:24
@ryanjbaxter
Copy link
Copy Markdown
Contributor

Can you please fix the checkstyle error and make this PR against the 4.1.x branch?

@qnnn qnnn force-pushed the refreshable-connectTimeout branch from 93fa296 to 03e99ad Compare April 23, 2025 06:27
@qnnn qnnn changed the base branch from main to 4.1.x April 23, 2025 06:27
@qnnn
Copy link
Copy Markdown
Contributor Author

qnnn commented Apr 23, 2025

Can you please fix the checkstyle error and make this PR against the 4.1.x branch?

Done. Please take a look.

@ryanjbaxter ryanjbaxter added this to the 4.1.8 milestone Apr 23, 2025
@ryanjbaxter ryanjbaxter merged commit 26f28fd into spring-cloud:4.1.x Apr 23, 2025
2 checks passed
@github-project-automation github-project-automation Bot moved this to Done in 2023.0.6 Apr 23, 2025
@spencergibb spencergibb moved this to Done in 2024.0.2 Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done
Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants