Support rewriting request parameters in mvc#3669
Merged
spencergibb merged 1 commit intospring-cloud:mainfrom Jan 31, 2025
Merged
Support rewriting request parameters in mvc#3669spencergibb merged 1 commit intospring-cloud:mainfrom
spencergibb merged 1 commit intospring-cloud:mainfrom
Conversation
Introduced a method to modify or replace request parameters during request processing, providing greater flexibility for parameter handling in routing. Signed-off-by: raccoonback <[email protected]>
3ecd882 to
ae14508
Compare
spencergibb
approved these changes
Jan 31, 2025
Been24
pushed a commit
to Been24/spring-cloud-gateway
that referenced
this pull request
Mar 14, 2025
Introduced a method to modify or replace request parameters during request processing, providing greater flexibility for parameter handling in routing. Signed-off-by: raccoonback <[email protected]> Signed-off-by: ubest <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Hello,
Currently, Spring Cloud Gateway provides a feature to replace HTTP Request Query Parameters through
RewriteRequestParameterGatewayFilterFactory.This Pull Request introduces the same functionality in spring-cloud-gateway-server-mvc, enabling developers to easily modify or replace Query Parameters in the MVC environment.
Motivation
the
rewriteRequestParameterfunction provides a simple and concise way to modify Query Parameters, as shown below:This approach consolidates the process of replacing a Query Parameter into a single method call, improving code clarity and reducing boilerplate.
Current Limitation
Currently, achieving the same result in the MVC environment requires two separate operations: removing and then adding the Query Parameter:
Proposed Solution
By introducing the
rewriteRequestParametermethod in MVC, developers can seamlessly handle both the removal and addition of Query Parameters in a single operation. This enhancement will:I look forward to your feedback and suggestions on this improvement.
Thanks!