Add a note about retry filter behavior in documentation#3534
Merged
spencergibb merged 3 commits intospring-cloud:mainfrom Sep 27, 2024
Merged
Add a note about retry filter behavior in documentation#3534spencergibb merged 3 commits intospring-cloud:mainfrom
spencergibb merged 3 commits intospring-cloud:mainfrom
Conversation
Member
|
I don't think specifying a specific order is right. It should be the order defined, and yes, users need to be aware. Maybe a documentation issue? |
Contributor
Author
Indeed, even if the order of the Retry filter is specified, other custom filters may still encounter the issue mentioned above. I have updated the PR title and added a description of this behavior in the corresponding documentation. |
qnnn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the priority of the GatewayFilter returned by RetryGatewayFilterFactory is not explicitly specified, which may lead to idempotency issues when used with other AbstractGatewayFilterFactory. For example, when AddRequestHeaderGatewayFilterFactory is configured after RetryGatewayFilterFactory, there may be issues with adding headers multiple times after a retry.
Perhaps it would be more appropriate for RetryGatewayFilterFactory to retry the ReactiveLoadBalancerClientFilter and the filters that follow. What do you think?