Declare Bean for the new public KeyValueConverter#3207
Merged
spencergibb merged 1 commit intospring-cloud:mainfrom Mar 6, 2024
Merged
Declare Bean for the new public KeyValueConverter#3207spencergibb merged 1 commit intospring-cloud:mainfrom
spencergibb merged 1 commit intospring-cloud:mainfrom
Conversation
martamedio
force-pushed
the
mmedio/keyvalue-config-fix
branch
from
d81ccf1 to
cfe1b3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, where we extract the
KeyValueconfiguration to allow using it in multiple filters, I forgot to initialize the associated Converter class in theGatewayAutoConfiguration🤦🏼♀️