@Guofuyinan Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@Guofuyinan Thank you for signing the Contributor License Agreement!

please add a test

I will add a test ASAP

Looks like some checkstyle issues.

Looks like some checkstyle issues.

Try again

@spencergibb any update?

We will get this included in the 2024.0 release train.

We will get this included in the 2024.0 release train.

@spencergibb any update?

Fixes #1759

Extract variables

@ryanjbaxter Any progress or anything I can do?

Can you submit this against the 4.2.x branch?

Can you submit this against the 4.2.x branch?

i have changed the base to 4.2.x branch

One final thing, could you add a note to the documentation that this setting will impact the path predicate?

One final thing, could you add a note to the documentation that this setting will impact the path predicate?

Sorry, I found that there is no webflux related content under the docs of spring-cloud:4.2.x branch, while the main branch has it. Should I cherry-pick from the spring-cloud:main branch and modify it?

If so, I plan to add the note to the 'The Path Route Predicate Factory' section in request-predicates-factories.adoc file.

I was just envisioning adding a note to the path predicate documentation that setting spring.webflux.base-path would influence he path. Were you thinking something else?

request-predicates-factories.adoc

Do you mean adding the note to the JavaDoc of org.springframework.cloud.gateway.route.RouteDefinition#predicates?
That sounds like a good approach for now.

I also think it would be helpful to include a note in the request-predicates-factories.adoc file as well.

We can definitely do this after the merge — I’d be happy to follow up on that.

I was thinking specifically here
https://github.com/spring-cloud/spring-cloud-gateway/blob/4.2.x/docs/modules/ROOT/pages/spring-cloud-gateway/request-predicates-factories.adoc#the-path-route-predicate-factory.

It would be good to have this documented before we merge it so everything is in one PR

I was thinking specifically here https://github.com/spring-cloud/spring-cloud-gateway/blob/4.2.x/docs/modules/ROOT/pages/spring-cloud-gateway/request-predicates-factories.adoc#the-path-route-predicate-factory.

It would be good to have this documented before we merge it so everything is in one PR

I've updated the documentation as suggested at the specific location you mentioned (request-predicates-factories.adoc#the-path-route-predicate-factory).

Added a paragraph explaining how the spring.webflux.base-path property influences path matching. The documentation now clearly states that this property value will be automatically prepended to path patterns, with an example included.