Add a method to nest boolean predicates#2598
Closed
puffnfresh wants to merge 1 commit intospring-cloud:mainfrom
Closed
Add a method to nest boolean predicates#2598puffnfresh wants to merge 1 commit intospring-cloud:mainfrom
puffnfresh wants to merge 1 commit intospring-cloud:mainfrom
Conversation
Spring Cloud Gateway supports complicated boolean predicates like:
(query("a") || query("b")) && (host("x") || host("y))
But lacked a Java API to express this. This new methods allows the above:
r.query("a").or().query("b").and().nested(p ->
r.host("x").or().host("y")
)
|
@puffnfresh Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@puffnfresh Thank you for signing the Contributor License Agreement! |
Contributor
Author
|
Sadly I don't know about general Spring API design decisions, but I would like to vote for that class to be public. |
Member
|
Scheduled for 2024.0. See 88b13ed for public |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spring Cloud Gateway supports complicated boolean predicates like:
But lacked a Java API to express this. This new method allows the above: