[gh-2288] Fix for redis rate limiter not working with multiple routes#2517
Conversation
|
That’s quite a drastic change because this means that it won’t be possible to share the same rate limiter across routes, whereas, before this PR, it was already possible to get per route rate limiters with a custom |
|
@DidierLoiseau I think you were operating a bit unintentionally where this fixed a real bug. I'm curious if the new bucket4j implementation might work in your case. I've also opened #3694 |
|
This is a breaking change. With a KeyResolver like this I could get the same result that is now imposed: The only option I think at this point is to duplicate the I hope this modification can be overhauled. |
This PR fixes (gh-2288) bug, which caused the same bucket is being reused by redis rate limiter over multiple routes.
The reason for this was a non-unique key that was created for storing bucket.
Now redis bucket key is unique between routes.