Skip to content

fix: Use exec for better PID 1 handling#2156

Merged
marcingrzejszczak merged 2 commits intospring-cloud:mainfrom
jakub-bochenski:patch-2
Feb 21, 2025
Merged

fix: Use exec for better PID 1 handling#2156
marcingrzejszczak merged 2 commits intospring-cloud:mainfrom
jakub-bochenski:patch-2

Conversation

@jakub-bochenski
Copy link
Copy Markdown
Contributor

Also pass the arguments along to the java execution

Previously the arguments were silently dropped

@marcingrzejszczak
Copy link
Copy Markdown
Contributor

Hey, thanks for the PR. Can you explain what the current problem is and how this solves it? Thank you

@jakub-bochenski
Copy link
Copy Markdown
Contributor Author

I thought this is a well known issue, e.g. see https://www.docker.com/blog/docker-best-practices-choosing-between-run-cmd-and-entrypoint/ "What is PID 1 and why does it matter?"

Also this is a problem on it's own:

Previously the arguments were silently dropped

@jakub-bochenski
Copy link
Copy Markdown
Contributor Author

Failed to execute goal org.antora:antora-maven-plugin:1.0.0-alpha.5:antora (default) on project spring-cloud-contract-docs: Antora failed to generate site successfully: Unable to execute com.github.eirslett:frontend-maven-plugin:1.15.0:npx (inspect prior log messages to find cause): Failed to run task: 'npx --offline antora --to-dir target/antora/site --stacktrace --fetch antora-playbook.yml' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]

I don't think this PR broke that

@marcingrzejszczak
Copy link
Copy Markdown
Contributor

I am no expert with Docker - I didn't know about that problem, thanks for pointing it out!

Yeah, don't worry about the issue with antora. Can you check the DCO check please?

Also pass the arguments along to the java execution

Previously the arguments were silently dropped

Signed-off-by: jakub-bochenski <[email protected]>
Signed-off-by: jakub <[email protected]>
Signed-off-by: jakub <[email protected]>
@jakub-bochenski
Copy link
Copy Markdown
Contributor Author

Yeah, don't worry about the issue with antora. Can you check the DCO check please?

No idea what happened there, as AFAIK I made both changes via Github Web UI.

I've rebased the commits, hopefully this resolves the issue

@marcingrzejszczak
Copy link
Copy Markdown
Contributor

Yeah, the antora build error is not related to your changes

@marcingrzejszczak marcingrzejszczak merged commit 5b2e7c0 into spring-cloud:main Feb 21, 2025
@marcingrzejszczak marcingrzejszczak modified the milestones: 5.0.0-M1, 4.2.0 Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants