fix: Use exec for better PID 1 handling#2156
fix: Use exec for better PID 1 handling#2156marcingrzejszczak merged 2 commits intospring-cloud:mainfrom
Conversation
|
Hey, thanks for the PR. Can you explain what the current problem is and how this solves it? Thank you |
|
I thought this is a well known issue, e.g. see https://www.docker.com/blog/docker-best-practices-choosing-between-run-cmd-and-entrypoint/ "What is PID 1 and why does it matter?" Also this is a problem on it's own:
|
I don't think this PR broke that |
|
I am no expert with Docker - I didn't know about that problem, thanks for pointing it out! Yeah, don't worry about the issue with antora. Can you check the DCO check please? |
Also pass the arguments along to the java execution Previously the arguments were silently dropped Signed-off-by: jakub-bochenski <[email protected]> Signed-off-by: jakub <[email protected]>
Signed-off-by: jakub <[email protected]>
ba6d8dc to
c872f70
Compare
No idea what happened there, as AFAIK I made both changes via Github Web UI. I've rebased the commits, hopefully this resolves the issue |
|
Yeah, the antora build error is not related to your changes |
Also pass the arguments along to the java execution
Previously the arguments were silently dropped