Skip to content

Workaround Gradle jvm-test-suite binary breaking change#2103

Merged
OlgaMaciaszek merged 2 commits intospring-cloud:mainfrom
shanman190:main
Mar 21, 2024
Merged

Workaround Gradle jvm-test-suite binary breaking change#2103
OlgaMaciaszek merged 2 commits intospring-cloud:mainfrom
shanman190:main

Conversation

@shanman190
Copy link
Copy Markdown
Contributor

Use reflection to avoid JVM level binary breaking change introduced in Gradle 8.6. Fixes gh-2098 and gh-2099

This is a forward merge of gh-2102.

@shanman190
Copy link
Copy Markdown
Contributor Author

shanman190 commented Mar 8, 2024

@OlgaMaciaszek, do you think that you'd be able to review this one?

I think the CI job just needs to be retriggered again to clear the failure as it looks like Maven was flaky on the CI run.

Copy link
Copy Markdown
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shanman190, looks good. Have added a cosmetic comment - please address. Also, please merge changes from origin/main so that the build can go through.

@OlgaMaciaszek
Copy link
Copy Markdown
Collaborator

@shanman190, I've pushed some changes to main to ensure the project builds correctly: https://github.com/spring-cloud/spring-cloud-contract/actions/runs/8358117918/job/22878713841. You might need to merge them. Please make sure the build passes.

@shanman190
Copy link
Copy Markdown
Contributor Author

🎉 Build succeeded 🎉

Copy link
Copy Markdown
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shanman190. LGTM.

@OlgaMaciaszek OlgaMaciaszek merged commit 5f75bad into spring-cloud:main Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gradle plugin fail on gradle version 8.6

3 participants