Add support to resolve credentials from settings.xml#1362
Add support to resolve credentials from settings.xml#1362marcingrzejszczak merged 2 commits intospring-cloud:masterfrom
Conversation
|
Hey @eddumelendez ! Thanks for the PR :) Do you think you could write a test for that? You could create a |
|
sure, I will! |
|
@marcingrzejszczak I have submit an additional commit with a test not sure if that is enough but TBH it was an interesting one many fixes 😃 |
marcingrzejszczak
left a comment
marcingrzejszczak
left a comment
There was a problem hiding this comment.
LGTM - had one small question though
| private void setField(Class<?> sourceClass, String fieldName, Object target, | ||
| Object value) { | ||
| try { | ||
| Field field = sourceClass.getDeclaredField(fieldName); |
There was a problem hiding this comment.
Wow, why do we have to do this?
There was a problem hiding this comment.
it is because DefaultSettingsDecrypter relies on maven so it will work for the maven plugin but not out of it.
Took inspiration from here
|
Thank you @eddumelendez. As usual, great job! :) |
3 participants
No description provided.