Contract maven plugin - incremental test generation#1361
Contract maven plugin - incremental test generation#1361marcingrzejszczak merged 2 commits intospring-cloud:masterfrom
Conversation
marcingrzejszczak
left a comment
There was a problem hiding this comment.
Thanks a lot for this pull request! Looks extremely interesting.
I've added a couple of remarks plus:
- Shouldn't we do the same for stubs?
- Can you please add some tests?
|
About plus:
Maybe. I made change for Java code generation, because lack of incrementalism trigger all test recompilation each build - and compilation is costly. Going back to stubs: do you mean both goals BTW, do you prefer single commit PR or multiple commits (and you will stash them on your side)
Well, PR is non-functional change, so existing tests should be enough |
Correct, thanks a lot.
Do however you please, I'll stash them upon merge.
👍 |
|
Great work @michaldo , thanks a lot! |
No description provided.