Skip to content

Contract maven plugin - incremental test generation#1361

Merged
marcingrzejszczak merged 2 commits intospring-cloud:masterfrom
michaldo:master
Apr 6, 2020
Merged

Contract maven plugin - incremental test generation#1361
marcingrzejszczak merged 2 commits intospring-cloud:masterfrom
michaldo:master

Conversation

@michaldo
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@marcingrzejszczak marcingrzejszczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this pull request! Looks extremely interesting.

I've added a couple of remarks plus:

  • Shouldn't we do the same for stubs?
  • Can you please add some tests?

Comment thread spring-cloud-contract-tools/spring-cloud-contract-maven-plugin/pom.xml Outdated
@michaldo
Copy link
Copy Markdown
Contributor Author

michaldo commented Apr 1, 2020

About plus:

Shouldn't we do the same for stubs?

Maybe. I made change for Java code generation, because lack of incrementalism trigger all test recompilation each build - and compilation is costly.

Going back to stubs: do you mean both goals convert and generateStubs should be incremental? Regardless their cost, it would be elegant to have incrementalism implemented for both. I already implemented that, so if you confirm both goals should be modified, I will update PR.

BTW, do you prefer single commit PR or multiple commits (and you will stash them on your side)

Can you please add some tests?

Well, PR is non-functional change, so existing tests should be enough

@marcingrzejszczak
Copy link
Copy Markdown
Contributor

Going back to stubs: do you mean both goals convert and generateStubs should be incremental? Regardless their cost, it would be elegant to have incrementalism implemented for both. I already implemented that, so if you confirm both goals should be modified, I will update PR.

Correct, thanks a lot.

BTW, do you prefer single commit PR or multiple commits (and you will stash them on your side)

Do however you please, I'll stash them upon merge.

Well, PR is non-functional change, so existing tests should be enough

👍

@marcingrzejszczak marcingrzejszczak merged commit 0a6d93a into spring-cloud:master Apr 6, 2020
@marcingrzejszczak
Copy link
Copy Markdown
Contributor

Great work @michaldo , thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants