Fix NPEs#1170
Merged
marcingrzejszczak merged 1 commit intospring-cloud:masterfrom Aug 13, 2019
anatoliy-balakirev:fix-npes
Merged
Fix NPEs#1170marcingrzejszczak merged 1 commit intospring-cloud:masterfrom anatoliy-balakirev:fix-npes
marcingrzejszczak merged 1 commit intospring-cloud:masterfrom
anatoliy-balakirev:fix-npes
Conversation
3 tasks
| return this.value instanceof RegexProperty | ||
| ? ((RegexProperty) this.value).pattern() : this.value.toString(); | ||
| if (this.value == null) { | ||
| return ""; |
Contributor
Author
There was a problem hiding this comment.
Not sure if this is what needs to be returned here...
Contributor
There was a problem hiding this comment.
There should be no such option that null is passed in. We can leave ""
Contributor
|
Can you rebase against master and try to build it again with the new base image for circleci? |
Codecov Report
@@ Coverage Diff @@
## master #1170 +/- ##
===========================================
- Coverage 2.27% 2.26% -0.01%
Complexity 18 18
===========================================
Files 60 60
Lines 2158 2161 +3
Branches 134 135 +1
===========================================
Hits 49 49
- Misses 2101 2104 +3
Partials 8 8
Continue to review full report at Codecov.
|
Contributor
Author
|
@marcingrzejszczak seems to be the same after rebase. |
Contributor
|
Jacoco was the culprit. Please rebase and it should work fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a couple of NPEs while testing something else.