File monitor should skip repository uris with placeholders#3112
Merged
ryanjbaxter merged 2 commits intospring-cloud:4.2.xfrom Oct 28, 2025
Merged
Conversation
spencergibb
approved these changes
Oct 28, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to skip file monitoring for SCM repository URIs that contain placeholders (e.g., {application}, {profile}, {label}). These placeholders cannot be resolved at startup time and would cause errors if the monitoring attempted to process them.
- Added logic to detect and skip URIs containing placeholders in the
getFileRepo()method - Added debug logging when placeholder URIs are skipped
- Added comprehensive test coverage for placeholder URI handling scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| FileMonitorConfiguration.java | Added placeholder detection logic to skip URIs containing { and log a warning message when placeholders are detected |
| FileMonitorConfigurationTest.java | Added three new test cases covering single placeholder URIs, mixed valid/placeholder URIs, and multiple placeholder types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…cloud/config/monitor/FileMonitorConfiguration.java Co-authored-by: Copilot <[email protected]> Signed-off-by: Ryan Baxter <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3095