Support YAML specific profile documents in AWS S3 buckets#2825
Merged
ryanjbaxter merged 1 commit intospring-cloud:4.1.xfrom Apr 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for YAML-specific profile documents stored in AWS S3 buckets. Key changes include:
- A new multi-document YAML file (foo.yaml) that separates non-profile and profile-specific configurations.
- Additional YAML and application configuration files for testing different profiles.
- Refactoring and extension of the S3 environment repository to support both YAML and properties/JSON file types.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spring-cloud-config-server/src/test/resources/awss3/foo.yaml | Introduces a multi-document YAML file with profile-specific configurations |
| spring-cloud-config-server/src/test/resources/awss3/foo-test1.yaml | Adds profile-specific test configuration |
| spring-cloud-config-server/src/test/resources/awss3/application.yaml | Adds non-profile-specific test configuration |
| spring-cloud-config-server/src/test/resources/awss3/application-test1.yaml | Adds profile-specific test configuration |
| spring-cloud-config-server/src/test/java/org/springframework/cloud/config/server/environment/AwsS3EnvironmentRepositoryTests.java | Implements a new test (multiDocumentYaml) to validate YAML multi-document processing |
| spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/environment/AwsS3EnvironmentRepository.java | Refactors property source addition and extends S3 file handling to support YAML, JSON, and properties |
Comments suppressed due to low confidence (1)
spring-cloud-config-server/src/test/resources/awss3/foo.yaml:6
- Inconsistent key naming: line 6 uses 'onProfile' while line 12 uses 'on-profile'. If both are not intended to have distinct meanings, consider standardizing the property key for clarity.
onProfile: test1
ryanjbaxter
force-pushed
the
support-profile-specific-yaml-documents
branch
from
de63c9a to
709c687
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2815