Make S3 and Git backends more compatible#2780
Merged
ryanjbaxter merged 4 commits intospring-cloud:mainfrom Mar 5, 2025
Merged
Conversation
Fixes spring-cloud#1829 Signed-off-by: Krzysztof Kurczewski <[email protected]>
ryanjbaxter
requested changes
Mar 5, 2025
Contributor
ryanjbaxter
left a comment
ryanjbaxter
left a comment
There was a problem hiding this comment.
Could you add some documentation for this?
Signed-off-by: kkurczewski <[email protected]>
Contributor
Author
|
Hi, added basic docs |
spencergibb
reviewed
Mar 5, 2025
| [[directory-layout]] | ||
| == Directory layout | ||
|
|
||
| Spring Cloud Config Server also supports per-app directory layout analogous to https://docs.spring.io/spring-cloud-config/docs/current/reference/html/#_placeholders_in_git_search_paths[`search-paths: '{application}'`] in Git backend, as shown in the following example: |
Member
There was a problem hiding this comment.
I bet we can do an asciidoc link without doing a fully qualified url. But I don't know how off the top of my head.
Contributor
Author
Signed-off-by: kkurczewski <[email protected]>
ryanjbaxter
requested changes
Mar 5, 2025
Signed-off-by: kkurczewski <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces new property
useDirectoryLayoutfor S3 backend:When enabled it behaves analogous to
searchPaths: {application}in Git backend, i.e. server will search S3 objects like:Which match git structure like:
Fixes #1829